Skip to content

Provide better docs for building on macOS#302

Merged
mohabsafey merged 1 commit intoalgebraic-solving:masterfrom
wegank:docs-fix-1
Mar 22, 2026
Merged

Provide better docs for building on macOS#302
mohabsafey merged 1 commit intoalgebraic-solving:masterfrom
wegank:docs-fix-1

Conversation

@wegank
Copy link
Contributor

@wegank wegank commented Mar 17, 2026

This should, hopefully, resolve #201.

@wegank wegank force-pushed the docs-fix-1 branch 2 times, most recently from 8afb28e to df1f988 Compare March 17, 2026 02:51
@wegank wegank marked this pull request as draft March 17, 2026 10:52
@ederc
Copy link
Contributor

ederc commented Mar 18, 2026

Fine for me.

@wegank wegank marked this pull request as ready for review March 19, 2026 09:12
@mohabsafey mohabsafey merged commit 6c9d63e into algebraic-solving:master Mar 22, 2026
11 of 12 checks passed
@dimpase
Copy link
Contributor

dimpase commented Mar 22, 2026

I think you need to pass -Xpreprocessor -fopenmp to clang.

And, if you use a standard GNU libtool to link, to make sure that this compiler flag does not leak into into the linker call (or patch libtool as in https://lists.gnu.org/archive/html/libtool/2026-02/msg00003.html)

@wegank wegank deleted the docs-fix-1 branch March 22, 2026 10:31
@wegank
Copy link
Contributor Author

wegank commented Mar 22, 2026

The updated documentation recommends using LLVM Clang instead of Apple's, and the former does not need the -Xpreprocessor hack. Would you like to add support for Apple Clang?

@dimpase
Copy link
Contributor

dimpase commented Mar 22, 2026

The updated documentation recommends using LLVM Clang instead of Apple's, and the former does not need the -Xpreprocessor hack. Would you like to add support for Apple Clang?

Homebrew builds msolve with Apple clang. That's the one I meant in #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provide better support (docs?) for building with clang

4 participants