Skip to content

Fix issue310#322

Merged
mohabsafey merged 6 commits intoalgebraic-solving:masterfrom
jerebertho:fix_issue310
Mar 26, 2026
Merged

Fix issue310#322
mohabsafey merged 6 commits intoalgebraic-solving:masterfrom
jerebertho:fix_issue310

Conversation

@jerebertho
Copy link
Copy Markdown
Contributor

@jerebertho jerebertho commented Mar 25, 2026

This PR fixes issue #310

  1. When the DRL Gröbner basis has a linear form x_n - a, there was issue in the change of order step,especially to compute the minimal polynomial of x_n. This could yield problems when computing the parametrizations.
  2. The degree of the minimal polynomial of x_n and that of its squarefree part were tracked several times in the change of order algorithm. This has been simplified.
  3. The computation of the inverse of the Hankel matrix, for computing the parametrizations, was wrong in a rare case that happens with probability 1/p, where p is the characteristic of the field. Since in issue Segmentation fault with a simple example #310 , the characteristic was 7, the problem was quite frequent.

@mohabsafey mohabsafey merged commit a7b3efe into algebraic-solving:master Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants