Conversation
aseure
reviewed
Jul 5, 2019
[changelog] Adds the possibility to compress POST/PUT requests for SearchClient. For the moment only GZIP compression is available. GZIP compression is enabled by default for SearchClient.
aseure
approved these changes
Jul 10, 2019
aseure
left a comment
aseure
left a comment
There was a problem hiding this comment.
I'd say the PR is ready to merge as-is feature wise, hence my approval. Once thing you could consider though is to make the implementation not GZIP-specific. What I mean by that is that we chose to introduce an enum NONE/GZIP for the compression type instead of a boolean. However, when it comes to serialization, we don't switch among the different possibilities. This is definitely nitpicking as we don't plan to have any other compression format any time soon and it is clearly internal design, hence the approval :) Up to you buddy.
From a functional point of view, super good change! Thank you again for leading this with the engine team @Ant-hem 👍 👍 👍
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the possibility to compress request for SearchClient.
For the moment only GZIP compression is available.
GZIP compression is enabled by default for SearchClient.
AccountClienttest is expected to fail because the feature is not enabled on the second test server yet.