Skip to content

Conversation

@thegnuu
Copy link
Contributor

@thegnuu thegnuu commented Sep 13, 2024

When using this library with the newest angular version (v18.2.2), the following error will be thrown.

You can "fix" the issue by using noImplicitOverride: false in the tsconfig, but I guess it would make sense to fix it here...

✖ Compiling with Angular sources in Ivy partial compilation mode.
node_modules/@algolia/client-common/src/transporter/errors.ts:4:3 - error TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Error'.

4   name: string = 'AlgoliaError';

This PR adds the missing override property and should fix this issue.

@stevengunneweg
Copy link

I also need this feature. I hope this can be reviewed and merged soon!

@shortcuts
Copy link
Member

Hey there, thanks for opening the PR!

The code of this repository is fully generated, so i'm moving your PR to algolia/api-clients-automation#3785

The addition looks great, I just need to double check if there's potential compatibility issue

@shortcuts shortcuts closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants