Skip to content

Conversation

@julienbourdeau
Copy link

🎁

@julienbourdeau julienbourdeau force-pushed the update/githubdir branch 3 times, most recently from 37f80a1 to 1d61c26 Compare March 20, 2018 15:55
@julienbourdeau
Copy link
Author

The PR was updated, please have a look and merge if no issue were found

@julienbourdeau julienbourdeau force-pushed the update/githubdir branch 2 times, most recently from f1624d8 to 0953daa Compare March 21, 2018 17:37
@julienbourdeau
Copy link
Author

The PR was updated, please have a look and merge if no issue were found

@julienbourdeau julienbourdeau force-pushed the update/githubdir branch 4 times, most recently from 850ad90 to f18bf48 Compare March 21, 2018 18:03
@julienbourdeau
Copy link
Author

The PR was updated, please have a look and merge if no issue were found

PLNech
PLNech previously requested changes May 17, 2018
LICENSE Outdated

Copyright (c) 2013 Algolia
http://www.algolia.com/
Copyright (c) 2014-Present Algolia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in for -Present, but why moving from 2013 to 2014? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clients use the same Licence file, I guess Python is one of the older. I'll how ot change that

MAINTAINERS.md Outdated
| Name | Email |
|------------------|-----------------------------|
| Léo Ercolanelli | leo.ercolanelli@algolia.com |
| Paul-Louis Nech | support@algolia.com |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK I'm not the maintainer of this package ¯_(ツ)_/¯

@julienbourdeau
Copy link
Author

The PR was updated, please have a look and merge if no issue were found

@julienbourdeau julienbourdeau dismissed PLNech’s stale review May 31, 2018 14:50

fixed! Thank you PLN for carefully reviewing 🙏

@julienbourdeau julienbourdeau merged commit a5d4780 into algolia:master May 31, 2018
@julienbourdeau julienbourdeau deleted the update/githubdir branch May 31, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants