Reset customer group collection after filtering #1699
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without clearing customer group collection, any loops on existing collection will not be filtered
Contributor
|
@kamilszewczyk Thank you for identifying this bug! This is a sensible fix and we'll be sure to include it in a future patch release. |
Contributor
|
Thanks a lot for your contribution @kamilszewczyk ! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without clearing customer group collection, any loops on existing collection will not be filtered
Summary
Add field filtering without clearing the collection (or creating new instance of it) will not actually do anything. Excluding websites should speed up the process of indexing by not requiring retrieval of grouped prices in websites that are excluded.
Without this modification this code doesn't do anything.
Result
With Customer Group pricing option enabled, any runs of
foreach ($this->groups as $group)for example in vendor/algolia/algoliasearch-magento-2/Helper/Entity/Product/PriceManager/ProductWithChildren.php::setFinalGroupPrices should only loop through customer groups that are NOT excluded in the current website scope.Without the change:
After the change:
