Skip to content

Conversation

@cammonro
Copy link
Contributor

@cammonro cammonro commented Mar 4, 2025

Summary

This primary of objective of this PR is introduce default renderingContent that will help power dynamicWidgets. It also includes some refactoring:

  • New FacetBuilder service
  • Shared rawFacets between renderingContent and attributesForFaceting
  • Separating logic into functions by area of concern: groups, categories,
  • Introducing constants for Magento integration specific key conventions
  • Added unit tests and reorganized existing

During implementation it was observed that our currency handling is flawed as it does not handle scoped currency config by store but this PR does not address that issue. That will be addressed in a separate ticket.

Result

renderingContent persisted as Facet Display in Dashboard:
image

All tests passed (including reorganized tests)
image

@cammonro cammonro requested a review from damcou March 4, 2025 14:56
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work 🚀

I just have questions more than changes requested, I think you can merge it afterwards

@cammonro cammonro merged commit 18b0db9 into release/3.16.0-dev Mar 5, 2025
3 checks passed
@cammonro cammonro deleted the feat/MAGE-973-rendering-content branch March 5, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants