-
Notifications
You must be signed in to change notification settings - Fork 171
MAGE-973 Default renderingContent #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceting and renderingContent
damcou
approved these changes
Mar 5, 2025
Contributor
damcou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work 🚀
I just have questions more than changes requested, I think you can merge it afterwards
damcou
reviewed
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This primary of objective of this PR is introduce default
renderingContentthat will help powerdynamicWidgets. It also includes some refactoring:FacetBuilderservicerawFacetsbetweenrenderingContentandattributesForFacetingDuring implementation it was observed that our currency handling is flawed as it does not handle scoped currency config by store but this PR does not address that issue. That will be addressed in a separate ticket.
Result
renderingContentpersisted as Facet Display in Dashboard:All tests passed (including reorganized tests)
