-
Notifications
You must be signed in to change notification settings - Fork 27
feat(scripts): add pushToRepository script
#4114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. 📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
Hey, I think you need to rebase you branch with main to fix the CI issue :) |
4a9e870 to
4e354c5
Compare
Thanks for the tip @millotp! |
|
hey @levimichael i'm doing some changes on your PR as I need to also push to AlgoliaWeb for the ingestion API, so I'll make it work for every other repos/tasks |
pushToRepository script
|
wonderful idea @levimichael :D nothing to add to the pr, I'll let @millotp review it as I've already contributed |
Fluf22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
| ALGOLIA_APPLICATION_ID: 'YourApplicationID', | ||
| ALGOLIA_API_KEY: 'YourWriteAPIKey', | ||
| '<YOUR_INDEX_NAME>': 'movies_index', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand what the use case is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah actually since we re-use the snippets, the guide has no control over the variable names of the generated part, so this allows the guide receiver to use their own variable values
There might be an issue with the Ingestion client
Fluf22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
|
Ah amazing @shortcuts! Glad it was already useful for you. Thanks for your contributions as well. |
🧭 What and Why
https://algolia.atlassian.net/browse/DI-3222
This PR includes changes to make it easier for contributors to manage which repos receive automatic PRs when guides are updated.
It adds a config file which simplifies configurations without custom scripting for every new repo.