Skip to content

Conversation

@levimichael
Copy link
Contributor

@levimichael levimichael commented Nov 15, 2024

🧭 What and Why

https://algolia.atlassian.net/browse/DI-3222

This PR includes changes to make it easier for contributors to manage which repos receive automatic PRs when guides are updated.

It adds a config file which simplifies configurations without custom scripting for every new repo.

@levimichael levimichael requested a review from a team as a code owner November 15, 2024 22:55
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 15, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1658
javascript 1603
php 1477
csharp 1325
python 1107
java 1104
ruby 890
swift 753

@levimichael levimichael changed the title feat(guides): push to repo feat(ci): push to repo Nov 15, 2024
@millotp
Copy link
Collaborator

millotp commented Nov 18, 2024

Hey, I think you need to rebase you branch with main to fix the CI issue :)

@levimichael
Copy link
Contributor Author

Hey, I think you need to rebase you branch with main to fix the CI issue :)

Thanks for the tip @millotp!

@github-actions
Copy link

github-actions bot commented Nov 18, 2024

@shortcuts
Copy link
Member

hey @levimichael i'm doing some changes on your PR as I need to also push to AlgoliaWeb for the ingestion API, so I'll make it work for every other repos/tasks

@shortcuts shortcuts changed the title feat(ci): push to repo feat(scripts): add pushToRepository script Nov 19, 2024
@shortcuts
Copy link
Member

wonderful idea @levimichael :D nothing to add to the pr, I'll let @millotp review it as I've already contributed

Fluf22
Fluf22 previously approved these changes Nov 19, 2024
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Comment on lines +40 to +42
ALGOLIA_APPLICATION_ID: 'YourApplicationID',
ALGOLIA_API_KEY: 'YourWriteAPIKey',
'<YOUR_INDEX_NAME>': 'movies_index',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand what the use case is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah actually since we re-use the snippets, the guide has no control over the variable names of the generated part, so this allows the guide receiver to use their own variable values

@Fluf22 Fluf22 dismissed their stale review November 19, 2024 13:56

There might be an issue with the Ingestion client

@shortcuts shortcuts requested a review from Fluf22 November 19, 2024 14:10
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@shortcuts shortcuts merged commit 45e54bd into main Nov 19, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/push-to-repo branch November 19, 2024 15:16
@levimichael
Copy link
Contributor Author

Ah amazing @shortcuts! Glad it was already useful for you. Thanks for your contributions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants