Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

Composition API will introduce new behaviours soon. In order to make a clear separation of concern and reusable, extract everything related to injection behaviour into a dedicated directory

Changes included:

This PR should be transparent, no change on the clients directly

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team November 26, 2025 14:43
@ClaraMuller ClaraMuller requested a review from a team as a code owner November 26, 2025 14:43
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 26, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 8e1cc5cfcb74d1f45ed70d2eea26e74dc5e29f77
🍃 Generated commit 4eefe778fcabcf302dfd4b01ca01b1a1b5eb9bb6
🌲 Generated branch generated/clara/feat/add-injection-metadata
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2481
go 2280
php 1890
csharp 1374
python 1351
java 1185
ruby 873
swift 474
scala 23

@ClaraMuller
Copy link
Contributor Author

ClaraMuller commented Nov 27, 2025

➡️ Solved

	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
	===  UNCHANGED SUPERCLASS: java.lang.Object (<- java.lang.Object)
	***! MODIFIED METHOD: PUBLIC com.algolia.model.composition.InjectionBehaviour (<-com.algolia.model.composition.Injection) getInjection()
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.CompositionBehavior setInjection(com.algolia.model.composition.Injection)
---! REMOVED CLASS: PUBLIC(-) com.algolia.model.composition.Injection  (not serializable)
	---  CLASS FILE FORMAT VERSION: n.a. <- 52.0
	---! REMOVED SUPERCLASS: java.lang.Object
	---! REMOVED CONSTRUCTOR: PUBLIC(-) Injection()
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Injection addInjectedItems(com.algolia.model.composition.InjectedItem)
	---! REMOVED METHOD: PUBLIC(-) boolean equals(java.lang.Object)
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Deduplication getDeduplication()
	---! REMOVED METHOD: PUBLIC(-) java.util.List<com.algolia.model.composition.InjectedItem> getInjectedItems()
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Main getMain()
	---! REMOVED METHOD: PUBLIC(-) int hashCode()
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Injection setDeduplication(com.algolia.model.composition.Deduplication)
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Injection setInjectedItems(java.util.List<com.algolia.model.composition.InjectedItem>)
	---! REMOVED METHOD: PUBLIC(-) com.algolia.model.composition.Injection setMain(com.algolia.model.composition.Main)
	---! REMOVED METHOD: PUBLIC(-) java.lang.String toString()
+++  NEW CLASS: PUBLIC(+) FINAL(+) kotlin.collections.builders.SerializedCollection  (changed from Serializable to Externalizable)
	+++  CLASS FILE FORMAT VERSION: 52.0 <- n.a.
	+++  NEW SUPERCLASS: java.lang.Object```

@ClaraMuller ClaraMuller force-pushed the clara/feat/add-injection-metadata branch from d3937bf to 3b01d4e Compare November 28, 2025 09:00
Copy link
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@millotp millotp merged commit b0ae74e into main Nov 28, 2025
33 checks passed
@millotp millotp deleted the clara/feat/add-injection-metadata branch November 28, 2025 09:58
algolia-bot added a commit that referenced this pull request Nov 28, 2025
…wn directory (#5683) (generated) [skip ci]

Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants