-
Notifications
You must be signed in to change notification settings - Fork 28
refactor(specs): extract composition injection behaviour into its own directory
#5683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+241
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Contributor
Author
|
➡️ Solved |
millotp
reviewed
Nov 27, 2025
specs/composition/common/schemas/components/injection/Behaviour.yml
Outdated
Show resolved
Hide resolved
d3937bf to
3b01d4e
Compare
millotp
approved these changes
Nov 28, 2025
Contributor
millotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
algolia-bot
added a commit
that referenced
this pull request
Nov 28, 2025
…wn directory (#5683) (generated) [skip ci] Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Composition API will introduce new behaviours soon. In order to make a clear separation of concern and reusable, extract everything related to
injectionbehaviour into a dedicated directoryChanges included:
This PR should be transparent, no change on the clients directly
🧪 Test
yarn cli build specs all && yarn cli build clients javascript