-
Notifications
You must be signed in to change notification settings - Fork 28
feat(specs): add new composition endpoint to update sortingStrategy #5689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: benk/sortby
Are you sure you want to change the base?
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
5f01361 to
ade0a86
Compare
ade0a86 to
788ff6a
Compare
788ff6a to
ba012b9
Compare
aa1c6d5 to
8760621
Compare
|
Probably worth to mentioning in the description that there is a stack PRs |
| x-acl: | ||
| - editSettings | ||
| summary: Set or update the "sortingStrategy" configuration for an existing composition | ||
| description: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put a warning that we can't check that the sorting strategy is valid in this endpoint ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good idea, added warning
68ba6d5 to
e9d8728
Compare
6cbba4e to
4ec654a
Compare
e9d8728 to
6f7519d
Compare
4ec654a to
df9b4f5
Compare
6f7519d to
8135795
Compare
df9b4f5 to
2344d86
Compare
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-631
Changes included:
/1/compositions/{compositionID}/sortingStrategyStacked PRs
🧪 Test