Skip to content

Conversation

@ben-kalmus
Copy link
Contributor

@ben-kalmus ben-kalmus commented Nov 27, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-631

Changes included:

  • Added new endpoint /1/compositions/{compositionID}/sortingStrategy

Stacked PRs

🧪 Test

  • generated CTS test for new endpoint

@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 27, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 507e467fa06c480d3d080a962ac51dab52df169d
🍃 Generated commit 811cc70c3742ca16a72690353468ac5712442486
🌲 Generated branch generated/benk/update-sortingStrategy-endpoint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2421
go 2309
php 1901
csharp 1497
python 1336
java 1191
ruby 919
swift 899
scala 23

@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch from 5f01361 to ade0a86 Compare November 27, 2025 15:39
@ben-kalmus ben-kalmus changed the base branch from main to benk/sortby November 27, 2025 15:40
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch from ade0a86 to 788ff6a Compare November 27, 2025 15:46
@ben-kalmus ben-kalmus changed the title Benk/update sorting strategy endpoint feat(specs): add new composition endpoint to update sortingStrategy Nov 27, 2025
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch from 788ff6a to ba012b9 Compare November 27, 2025 15:58
@ben-kalmus ben-kalmus marked this pull request as ready for review November 27, 2025 15:58
@ben-kalmus ben-kalmus requested a review from a team as a code owner November 27, 2025 15:58
@ben-kalmus ben-kalmus requested review from morganleroi and shortcuts and removed request for a team November 27, 2025 15:58
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch 2 times, most recently from aa1c6d5 to 8760621 Compare November 27, 2025 16:09
@ClaraMuller
Copy link
Contributor

ClaraMuller commented Nov 28, 2025

Probably worth to mentioning in the description that there is a stack PRs

@ClaraMuller ClaraMuller requested a review from a team November 28, 2025 07:41
x-acl:
- editSettings
summary: Set or update the "sortingStrategy" configuration for an existing composition
description: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a warning that we can't check that the sorting strategy is valid in this endpoint ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea, added warning

@ClaraMuller ClaraMuller requested a review from a team November 28, 2025 07:42
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch 2 times, most recently from 6cbba4e to 4ec654a Compare November 28, 2025 10:38
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch from 4ec654a to df9b4f5 Compare November 28, 2025 10:52
@ben-kalmus ben-kalmus force-pushed the benk/update-sortingStrategy-endpoint branch from df9b4f5 to 2344d86 Compare November 28, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants