feat(shared): introduce autocomplete-shared package #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6ec55e:
|
Haroenv
reviewed
Nov 5, 2020
| "@algolia/autocomplete-shared": "1.0.0-alpha.34" | ||
| }, | ||
| "devDependencies": { | ||
| "@algolia/client-search": "4.5.1", |
Contributor
There was a problem hiding this comment.
is this one only used in tests? otherwise it should be also in peerDependencies; even if it's a transitive dependency (I think).
Contributor
Author
There was a problem hiding this comment.
It's to use the Hit type: https://github.com/algolia/autocomplete.js/blob/25316b82e0fbe2d3091e41d572c338e825e87a15/packages/autocomplete-preset-algolia/src/highlight/parseAlgoliaHitHighlight.ts#L2
So yeah it should be in peer deps I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables to share code between packages by introducing a new package:
@algolia/autocomplete-shared.This package is only compiled to ESM (no UMD) because it's meant to stay internal. We could have not transpiled it at all (i.e., shipping TypeScript files) but we might break apps using the ESM imports of our libs that don't transpile TS files.