Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

feat(cli): add default Algolia credentials #291

Merged
merged 2 commits into from
Oct 23, 2018
Merged

feat(cli): add default Algolia credentials #291

merged 2 commits into from
Oct 23, 2018

Conversation

@quentin-sommer
Copy link
Contributor

@quentin-sommer quentin-sommer commented Oct 17, 2018 •
edited
Loading

Uses the inquirer default value feature

closes #290

@quentin-sommer quentin-sommer changed the title feat: Added default values for appId and apiKey closes #290 fix: Added default values for appId and apiKey closes #290 Oct 17, 2018
francoischalifour
francoischalifour suggested changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@francoischalifour francoischalifour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

It'd be awesome to also default indexName to instant_search to make the app usable straight from the command line. This is the index we use for demos on the application latency.

@francoischalifour francoischalifour changed the title fix: Added default values for appId and apiKey closes #290 feat(cli): add default Algolia credentials Oct 18, 2018
@quentin-sommer
Copy link
Contributor Author

quentin-sommer commented Oct 18, 2018

thanks @Haroenv! @francoischalifour it's updated 👍

francoischalifour
francoischalifour approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francoischalifour francoischalifour merged commit b3dc47f into algolia:master Oct 23, 2018
@quentin-sommer quentin-sommer deleted the fix/290 branch October 23, 2018 09:54
aymeric-giraudet pushed a commit to algolia/instantsearch that referenced this pull request Dec 14, 2022
@quentin-sommer @francoischalifour
feat(cli): add default Algolia credentials (algolia/create-instantsea…
9182748 
…rch-app#291)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@francoischalifour francoischalifour francoischalifour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide demo credentials as an option

3 participants

@quentin-sommer @francoischalifour @Haroenv