feat(react): port MenuSelect, NumericMenu, and RatingMenu#7031
Draft
aymeric-giraudet wants to merge 1 commit into
Draft
feat(react): port MenuSelect, NumericMenu, and RatingMenu#7031aymeric-giraudet wants to merge 1 commit into
aymeric-giraudet wants to merge 1 commit into
Conversation
Closes the three remaining gaps in `react-instantsearch` that the `port-widget` skill audit surfaced: - **MenuSelect**: a variant of `Menu` that reuses `useMenu`, renders a plain `<select>` UI with `defaultOption`/`itemLabel` escape hatches, and sets `$$widgetType: 'ais.menuSelect'`. - **NumericMenu**: thin wrapper around the existing `useNumericMenu` hook. UI is a radio-button list matching the `ais-NumericMenu-*` class names used by the JS and Vue flavors. - **RatingMenu**: adds a new `useRatingMenu` hook to `react-instantsearch-core`, plus a presentational UI component that renders the SVG star symbols, anchor links with `aria-label`, and modifier-click handling for opening in a new tab. Replaces the corresponding "X is not supported in React InstantSearch" test placeholders with real render setups, removes the `skippedTests` entries, and wires the widgets into `__utils__/all-widgets.tsx` so SSR coverage applies.
3 tasks
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 27 |
| Duplication | 1 |
TIP This summary will be updated as you push new changes.
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #7030.
Summary
Closes the three remaining React widget gaps from the port-widget skill audit. Each ported widget pairs a hook (in `react-instantsearch-core`) with a public widget and a presentational UI component in `react-instantsearch`.