Skip to content
This repository was archived by the owner on Dec 30, 2022. It is now read-only.

docs(hits): ensure key is always objectID#293

Merged
mthuret merged 4 commits intomasterfrom
docs/hits-key
Sep 4, 2017
Merged

docs(hits): ensure key is always objectID#293
mthuret merged 4 commits intomasterfrom
docs/hits-key

Conversation

@mthuret
Copy link
Contributor

@mthuret mthuret commented Aug 31, 2017

see #289

@mthuret mthuret changed the title wip docs(hits): ensure key is always objectID Aug 31, 2017
@algobot
Copy link
Contributor

algobot commented Aug 31, 2017

Deploy preview ready!

Built with commit bd85f0d

https://deploy-preview-293--react-instantsearch.netlify.com

@algobot
Copy link
Contributor

algobot commented Aug 31, 2017

Deploy preview ready!

Built with commit 876360f

https://deploy-preview-293--react-instantsearch.netlify.com

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, I'm wondering if we can do something in the Hits widget itself though 🤔

@mthuret
Copy link
Contributor Author

mthuret commented Sep 4, 2017

@Haroenv the Hits and InfiniteHits widget already set the key to objectID.

@mthuret mthuret merged commit 664b3c6 into master Sep 4, 2017
@mthuret mthuret deleted the docs/hits-key branch September 4, 2017 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants