fix(recommend): ignore items type in components#37
Merged
francoischalifour merged 2 commits intonextfrom Jun 17, 2021
Merged
Conversation
shortcuts
reviewed
Jun 17, 2021
shortcuts
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a typing issue raised by the Dashboard team where
itemswas marked as required in our FBT and RP components.We forgot to omit the
itemsprop which is only used by the VDOM components.I took the opportunity to fix other typing inconsistencies where we expected the VDOM component to receive
GetRelatedProductsProps, whereas it's only expect at the renderer packages' level (React and JS).