Remove doctrine event subscriber when not used#219
Merged
julienbourdeau merged 1 commit intoMar 22, 2018
Conversation
Contributor
|
That works very well! Thanks for your contribution :) Feel free to open more pull request 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as in #218: despite I'm not subscribing to doctrine events right now, accessing the entity manager will instantiate the client uselessly. So removing the subscriber when configured explicitly to not listen anything makes sense.
Also the parameter
algolia_search.doctrineSubscribedEventsisn't really useful and isn't the common practice to set service definition arguments based on configuration (the parameter will remains accessible on userland).