fix: do waitTask on all tasks before moving index

[DevinCodes]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no

Describe your change

This updates the SearchImport command to wait until all indexing operations are done before performing a moveIndex operation. This could prevent accidental loss of data.

[DevinCodes]

@chloelbn have you seen this error in the CI before? 🤔

[matthewbond]

The change looks great, for the CI errors, if I understand this change right: symfony/symfony#40986 then getOption will now sometimes return null, could this be why there are these errors in the CI?

[DevinCodes]

@matthewbond You're right, fixed this in c2df2d4.

I was referring to the following error however:

Fatal error: Could not check compatibility between Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Zend\Code\Generator\ClassGenerator $classGenerator): void and ProxyManager\ProxyGenerator\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Laminas\Code\Generator\ClassGenerator $classGenerator), because class Zend\Code\Generator\ClassGenerator is not available in /home/circleci/project/vendor/symfony/proxy-manager-bridge/LazyProxy/PhpDumper/LazyLoadingValueHolderGenerator.php on line 33

It looks like this comes from the fact that v3.4 of Symfony is no longer supported. I've dropped support for the older version of Symfony in d618f45.

[DevinCodes]

This issue mentions a fix: requiring the laminas/laminas-zendframework-bridge dependency. Added that in 3ab55be

[DevinCodes]

@matthewbond should be good now 😄

[matthewbond]

LGTM