fix: ensure session is persisted before OAuth callback returns#220
Open
lwzbwtj wants to merge 1 commit intoalgora-io:mainfrom
Open
fix: ensure session is persisted before OAuth callback returns#220lwzbwtj wants to merge 1 commit intoalgora-io:mainfrom
lwzbwtj wants to merge 1 commit intoalgora-io:mainfrom
Conversation
Fixes race condition where frontend checks session before cookie is set. The issue: OAuth callback completes successfully on backend, but frontend request may hit a race condition or stale session state during redirect, causing 500 error. The fix: Explicitly call configure_session(persist: true) after setting session values to ensure the session cookie is properly saved before the response is sent to the client. Closes algora-io#186
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes race condition where frontend checks session before cookie is set.
Problem
OAuth callback completes successfully on backend, but frontend request may hit
a race condition or stale session state during redirect, causing 500 error.
After refreshing the page, the session works correctly.
Solution
Explicitly call configure_session(persist: true) after setting session values
to ensure the session cookie is properly saved before the response is sent
to the client.
Changes
Checklist
Closes #186