chore: add commonJS support#1
Merged
Merged
Conversation
Member
|
thanks caleb, can you |
Contributor
Author
|
Awesome! I'll do this and let you know how it goes. |
Contributor
Author
@zcesur, I'm still facing this issue. |
Contributor
Author
|
So uhm... @zcesur, I tried publishing a fork of this package that supports commonJS and it worked. You can take a look at the package here. The GitHub bot works now without the vercel error. Take a look at the latest comment here. This pull request fixes the commonJS issue. Kindly let me know when you've published a new version so I can install the algora/sdk again. |
Member
|
awesome, just published a new version! 🙏 |
Contributor
Author
|
Thank you, @zcesur! 🪔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zcesur, kindly take a look at this and lemme know if I'm on the right track.