fix: resolve silent failures in 'algokit project deploy' by improving error logging#718
Open
Tusharkhadde wants to merge 1 commit intoalgorandfoundation:mainfrom
Open
Conversation
… error logging and robustness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where
algokit project deploywould fail silently when errors occurred in the deployment configuration (e.g., anImportErrorindeploy_config.py).The silent failure was primarily caused by two factors:
deploycommand lacked an explicit fallback to display captured subprocess output when a failure occurred, relying solely on real-time logging which could be suppressed or interrupted.Changes
src/algokit/core/proc.py: Addederrors="backslashreplace"toproc.runto ensure that decoding errors in subprocess output are handled gracefully rather than crashing the CLI.src/algokit/cli/project/deploy.py: Added explicit logging of the captured subprocess output (at theERRORlevel) whenever the deployment command exits with a non-zero code. This aligns the behavior with theproject runcommand.Verification
Verified using a reproduction script that triggers an
ImportErrorand produces non-UTF-8 output. The CLI now correctly displays the Python traceback and error context even if real-time logging is insufficient.Related Issues
Closes #710