-
Notifications
You must be signed in to change notification settings - Fork 1
feat: deferred app calls, modular test context, refined access to value generators, numerous fixes/improvements #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel McGregor <daniel.mcgregor@makerx.com.au>
aorumbayev
commented
Jul 26, 2024
src/algopy_testing/op.py
Outdated
| "access the context manager." | ||
| ) | ||
|
|
||
| active_txn = context.get_active_transaction() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the active transaction could also have another method that returns a non None value.
Is there anywhere currently where returning non active context or transaction is allowed?
change local/global state storage to store values against the app, not the contract instance add UInt64Backed type to simplify serialization to/from int/bytes
…ontext with lazy_context
refactor: removing txn from method names inside txn context manager prop chore: restoring initial pre-commit refactor: expanding scoped_execution chore: remove redundant fields chore: addressing minor todos and removing the ones already addressed
aorumbayev
added a commit
that referenced
this pull request
Aug 12, 2024
Note that this patch is going to be reverted after the following PRs are merged (introducing final batch of changes) https://github.com/algorandfoundation/algorand-python-testing/pulls #4
algorand-python-testing
ad361a5 to
2ff4d05
Compare
algorand-python-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Now that the repo is migrated, below are the remaining abstractions left to implement prior to shifting to final refactor/polishing efforts
MISC