Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new ABI method arc89_get_metadata_partial_uri to retrieve the Asset Metadata ARC-90 partial URI without the compliance fragment. The implementation calls the existing arc90_box_query function with an empty box name to construct the URI.
Key Changes
- Added new readonly ABI method to retrieve the ARC-90 partial URI
- Refactored
Bytes(b"")toBytes()for cleaner empty bytes initialization - Updated TEAL compilation artifacts to include the new method routing
Reviewed changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
smart_contracts/asa_metadata_registry/interface.py |
Added abstract method declaration for arc89_get_metadata_partial_uri |
smart_contracts/asa_metadata_registry/contract.py |
Implemented the method by calling arc90_box_query with empty box name |
smart_contracts/avm_common.py |
Simplified empty Bytes initialization from Bytes(b"") to Bytes() |
tests/test_arc89_get_metadata_partial_uri.py |
Added test with workaround for broken .abi_return value |
smart_contracts/artifacts/asa_metadata_registry/AsaMetadataRegistry.approval.teal |
Updated TEAL bytecode with new method routing and arc90_box_query subroutine |
poetry.lock |
Reordered dependency markers and removed Python 3.8 wheel entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.