Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new ABI method arc89_get_metadata_b64_bytes_by_key that retrieves and decodes base64-encoded values from ASA metadata. The feature supports both URL-safe and standard base64 encoding schemes.
Key Changes
- Added
arc89_get_metadata_b64_bytes_by_keymethod that fetches a base64-encoded string from JSON metadata and returns the decoded bytes - Renamed
AsaMetadataRegistryInterfacetoArc89Interfacefor clarity - Enhanced documentation for existing metadata getter methods with improved formatting and clarity
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_arc89_get_metadata_b64_bytes_by_key.py | New test file with tests for both URL-safe and standard base64 encoding |
| tests/conftest.py | Added test data for base64-encoded values (both URL-safe and standard encodings) |
| smart_contracts/asa_metadata_registry/errors.py | Added validation error message for invalid base64 encoding parameter |
| smart_contracts/asa_metadata_registry/enums.py | Added enum constants for base64 encoding types (URL-safe = 0, Standard = 1) |
| smart_contracts/asa_metadata_registry/contract.py | Implemented new method with validation, decoding logic, and improved documentation for existing methods |
| smart_contracts/asa_metadata_registry/arc89_interface.py | Renamed interface class and added abstract method signature for the new feature |
| smart_contracts/artifacts/asa_metadata_registry/AsaMetadataRegistry.approval.teal | Updated compiled TEAL code with new method implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.