Added Haskell code for convolutions #39
Added Haskell code for convolutions #39leios merged 1 commit intoalgorithm-archivists:masterfrom jiegillet:master
Conversation
…it is very messy)
|
Looks good! Thanks for sending it in! =) |
|
I'm going to add Haskell to the book.json and describe what I changed there (I link the PR then). |
|
@julianschacherpp I thought haskell was already in the |
|
@leios you're right, it is |
|
Oh, @julianschacherpp I already made those changes and was going to push them in just a second. I realized the julia tags were also incorrect. |
|
I needed to add a small text blurb around the fft-based julia implementation. |
|
@leios ok, perfect :) |
|
Done. Thanks @jiegillet and @julianschacherpp ! You guys rock! =) |
|
edit: see below |
|
Thanks guys. I tried to mimic what I saw on another page (FFT I think), maybe I got it wrong ^^ |
|
@jiegillet the multiple languages with that book.json is quite new and we're missing documentation on that... so it's basically our fault :) edit: @jiegillet did everything right, the rest of the statement is still true |
|
@jiegillet To be fair, the name change from The only other change was just to make sure there was some code available in the fft box when people switch to haskell. What @julianschacherpp said... |
|
ohh, I was a wrong... that you didn't wrote hs instead of haskell is regarding the include-codeblock plug-in and doesn't affect theme-api at all. So you did everything about the theme-api right. That you used haskell instead of hs isn't really important, because this include-codeblock uses this table: http://highlightjs.readthedocs.io/en/latest/css-classes-reference.html#language-names-and-aliases I were wrong, sorry. |
|
@jiegillet me confused, see above, in case you didn't see my comment; sry |
I did not add FFT code as it is messy in Haskell AFAIK.
Added my name to contributors :p