bubblesort in v #631
bubblesort in v #631
Conversation
Liikt
added
Hacktoberfest
berquist
left a comment
berquist
left a comment
There was a problem hiding this comment.
Not sure how I missed this one.
You're missing the whole-file import in the chapter. Also, don't forget to revert the changes to book.json and .editorconfig now that they're already handled.
| arr := [1, 45, 756, 4569, 56, 3, 8, 5, -10, -4] | ||
| println('Array unsorted:') | ||
| println(arr) | ||
| bubblesort(mut arr) |
There was a problem hiding this comment.
Seems like a compiler bug that you can mutate this here when it isn't mut arr above.
There was a problem hiding this comment.
no i think it is intentional that this works. but i don't think it's idiomatic. i will change that.
this one i wrote waaaay back when i first learned about vlang and when doing function(mut var) would actually create a faulty program
There was a problem hiding this comment.
Considering that most of the bubble sort implementations mutate their input, if you declare mut arr := ..., I'll accept this.
contents/bubble_sort/bubble_sort.md
Outdated
| {% sample lang="bash" %} | ||
| [import:2-21, lang:"bash"](code/bash/bubble_sort.bash) | ||
| {% sample lang="v" %} | ||
| [import:2-21, lang:"v"](code/v/bubble_sort.v) |
There was a problem hiding this comment.
they probably aren't correct in any vlang pr 😓 will fix
2 participants
I found a cool new language in the making called V. so yeah this is bubblesort in V.