Thomas Algorithm in Ruby #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
Hacktoberfest
jiegillet
reviewed
Dec 19, 2019
Member
jiegillet
left a comment
jiegillet
left a comment
There was a problem hiding this comment.
This is pretty much identical to the Python implementation. Looks good to me!
Member
|
If you are happy with the code, I'll build it locally tomorrow and merge it in. Thanks! |
leios
approved these changes
Dec 19, 2019
Member
leios
left a comment
leios
left a comment
There was a problem hiding this comment.
If Jie says the code is good, I'm happy. It builds locally just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.