Cleaned up "Added Elm code for Euler, with visualization" (#62)#73
Merged
leios merged 2 commits intoalgorithm-archivists:masterfrom Mar 21, 2018
Butt4cak3:jie_euler_pr
Merged
Cleaned up "Added Elm code for Euler, with visualization" (#62)#73leios merged 2 commits intoalgorithm-archivists:masterfrom Butt4cak3:jie_euler_pr
leios merged 2 commits intoalgorithm-archivists:masterfrom
Butt4cak3:jie_euler_pr
Conversation
Member
|
If we are not using the html, I'd rather not include the full code at all, just the algorithm is enough. |
Member
|
Alright, we might need more discussion on this PR. Does it completely replace #62 ? |
Contributor
Author
|
@leios Yes. It is the same as the other PR but rebased and with one change. |
Member
|
Ok, so my understanding is that it's ready to merge? |
Contributor
Author
|
There's no open discussion about its content, so we should be good. Go ahead, Schloss Boss. |
Member
|
Cool. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a cleand up version of #62. I got the branch up-to-date with master and removed the already merged commits/merge commits. I also changed a bit that we (I think) collectively agreed on, which is that the HTML file is code output and should, for that and other reasons, not be included.
I preserved the original commit author, so that @jiegillet still shows up as the contributor of the code.