Multiple bug fixes: jump height, screen boundary, stuck items, and monster death by block.#49
Merged
algorithm0r merged 5 commits intoalgorithm0r:masterfrom Feb 24, 2025
Merged
Conversation
Mario is now constrained by the camera and cannot go off screen.
When Mario hits a block from below, it now kills enemies standing on top.
Faustjoe/minor bug fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
In this PR, I added a screen boundary so that Mario can no longer go offscreen.
Items also no longer get stuck and glitch on monsters.
Jump height was modified so that Mario can make a four block high jump without momentum like in the original game.
Monsters can now be killed by jump-punching the block beneath them.
Bugs
Contributors to the Feature
Jayden Fausto
Final check
Have you filled out this document and gave the pull request a descriptive name (Up on top of this document and the GitHub PR title)? Answer Yes and that means you are good to go! Thank you for your contribution.