Skip to content

Conversation

@einzigsue
Copy link
Contributor

allow the temporary file to have the same file extensions as the initial program.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2025

CLA assistant check
All committers have signed the CLA.

@codelion
Copy link
Member

codelion commented Aug 8, 2025

@einzigsue if you can sign the CLA I can merge this PR.

@einzigsue
Copy link
Contributor Author

signed.

@codelion
Copy link
Member

codelion commented Aug 9, 2025

@einzigsue can you take a look at the failing test as well?

@einzigsue
Copy link
Contributor Author

In order to get all current unit tests passing, I’ll need to update at lease three of them, namely,

  • test_artifacts_integration.py
  • test_artifacts.py
  • test_evaluator_timeout.py

Would you like me to include these test updates in the same PR?

According to my current understanding, the failing unit tests for config files/examples are caused by a mismatch with the new Evaluator API interface in the PR. Specifically, the updated Evaluator now needs to be aware of the file extension of the initial program to create the temporary file with the same extension. To address this, I will need to pass the file suffix into the Evaluator in all the affected unit test so it can initiate the evaluator correctly. For example, modify code here https://github.com/codelion/openevolve/blob/ddf42e265fb10917f251c8609f3cb3ebef3759c0/tests/test_artifacts.py#L157

to match the new API.
https://github.com/einzigsue/nci_openevolve/blob/03d7d2a9d22646a3789744a48287bdba2627f54a/openevolve/evaluator.py#L44

@codelion
Copy link
Member

@einzigsue can we fall back to the default py extension if it is not specified this should help ensure existing examples all run as is.

@codelion codelion merged commit 5a5bd3b into algorithmicsuperintelligence:main Aug 13, 2025
2 checks passed
wangcheng0825 pushed a commit to wangcheng0825/openevolve that referenced this pull request Sep 15, 2025
…nzigsue_adoption_suffix

einzigsue adoption [program suffix]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants