Use difficulty badge in problems table and remove unused dep#32
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Problems list UI to display a difficulty badge (instead of a raw value) and adjusts test setup/dependencies around environment configuration.
Changes:
- Render a difficulty badge in the Problems table “Difficulty” column.
- Update Vitest setup to mock
@/envvalues during tests. - Remove
dotenvfrom devDependencies / lockfile.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
vitest.setup.ts |
Replaces .env.test loading with a vi.mock("@/env") test-time env stub. |
src/features/problems/problems-table-v2/problems-columns-v2.tsx |
Renders a difficulty badge component in the Difficulty column. |
package.json |
Removes dotenv from devDependencies. |
pnpm-lock.yaml |
Removes dotenv entries from the lockfile. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
1
to
3
| import { ColumnDef } from "@tanstack/react-table"; | ||
| import { ProblemDifficultyBadge } from "@/features/problem/problem-difficulty-badge/problem-difficulty-badge"; | ||
| import { Problem } from "../models/problem"; |
Comment on lines
113
to
114
| "cypress": "^15.12.0", | ||
| "dotenv": "^17.2.3", | ||
| "eslint": "^9.39.1", |
Agent-Logs-Url: https://github.com/algowars/web/sessions/73ae2ae3-e122-4f5f-9093-eebfa71d7dfe Co-authored-by: admclamb <90528159+admclamb@users.noreply.github.com>
Agent-Logs-Url: https://github.com/algowars/web/sessions/73ae2ae3-e122-4f5f-9093-eebfa71d7dfe Co-authored-by: admclamb <90528159+admclamb@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/algowars/web/sessions/6b4202cb-2c5e-4625-bcca-15b363c40dce Co-authored-by: admclamb <90528159+admclamb@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.