chore: remove dead code, unused exports, etc#44
Merged
Conversation
Remove pre-OAuth `createBearerMiddleware`, unwired `searchByType`, unused `ToolName`/`MemoryStore` type exports, and `serverUrl` from `OAuthProviderOptions`. Replace hand-rolled JWT XOR comparison with `timingSafeEqual`. Replace test-only `clearConfigCache` with vitest `vi.resetModules()`. Scrub real IP and name from docs/fixtures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aliasunder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBearerMiddleware(unused since OAuth migration)searchByTypefrom search-index factory (vault_searchtype filter +vault_search_by_propertycover the same need)ToolName,MemoryStoreserverUrlfromOAuthProviderOptions(onlycreateOAuthRoutesuses it, where it's already received directly)timingSafeEqualfromnode:cryptoclearConfigCacheexport with vitestvi.resetModules()+ dynamic imports73.48.22.1→ RFC 5737203.0.113.42) from doc examplesTest plan
npx tsc --noEmit— clean compile, no dangling referencesnpm test— 461 tests pass (13 files), net -8 tests removed with dead codenpm run lint— cleangrep -rn "73.48.22.1"— no matches (IP scrubbed)grep -rn "Tanisha Aberdeen"— no matches (name scrubbed)🤖 Generated with Claude Code