feat: cache email RSA CryptoKeys by public key#2083
Merged
lanedirt merged 1 commit intoMay 29, 2026
Conversation
satisfy JSDoc lint
301dd60 to
ab1ee14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The email decrypt path currently imports the matching per-vault RSA private key from its JWK string every time an email/data is decrypted, this happens in decryptEmail, decryptEmailList and decryptAttachment
What changed now is not the vault schema rather we introduced a cache that caches keys as non-exctractable CryptoKey objects for the unlocked client session. The cache is keyed by the existing public-key match
EncyptionKey.PublicKey === email.encryptionKeyso it supports multiple RSA keys for future key rotation instead of assuming a single vault key. The cache is cleared when in-memory vault/session is cleared or locked. In the extension i also manually verified that opening the Emails tab imports once and subsequent email opens reuse the cached key whilst logout clears the cacheRelated Issues
Checklist