fix(Composer): skip send on Enter during IME composition#212
Open
greymoth-jp wants to merge 1 commit into
Open
fix(Composer): skip send on Enter during IME composition#212greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
The Composer Enter handler called send() on keyCode 13 without checking whether an IME composition was active. While composing CJK text (Japanese, Chinese, Korean), the Enter that confirms a conversion candidate also triggered send, so a half-composed message was submitted before the user finished typing. Guard the send with !e.nativeEvent.isComposing so Enter only sends once composition has ended. isComposing is on the native KeyboardEvent rather than the React synthetic event.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Composersends onEnter(keyCode === 13) without checking for an active IME composition. When typing CJK text (Japanese, Chinese, Korean), theEnterthat confirms a conversion candidate also fires the send, so a half-composed message gets submitted before the user is done.Fix
Add
!e.nativeEvent.isComposingto the existing guard, soEnteronly sends once composition has ended.isComposingis on the nativeKeyboardEventrather than the React synthetic event, hencee.nativeEvent.Verification
Render test (testing-library + jsdom): firing
keyDownwithkeyCode: 13, isComposing: trueno longer callsonSend; withisComposing: falseit still sends. Reverting the one-line guard makes the composing case send again.