fix(interactive): Fix a bug in insight runtime when eval empty string #4582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: bingqing.lbq from Dev container Committed-by: bingqing.lbq from Dev container
Contributor
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4582 +/- ##
=======================================
Coverage 33.02% 33.02%
=======================================
Files 127 127
Lines 13299 13299
=======================================
Hits 4392 4392
Misses 8907 8907 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
BingqingLyu
force-pushed
the
fix_empty_string_eval
branch
2 times, most recently
from
517f2a3 to
034aa70
Compare
BingqingLyu
force-pushed
the
fix_empty_string_eval
branch
from
034aa70 to
a126733
Compare
Committed-by: bingqing.lbq from Dev container
shirly121
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled, this bug occurs because an Object with an empty string is incorrectly treated as NULL, leading
NULL==NULLto evaluate as false. However, the comparison""==""should be true. This PR addresses and fixes the issue.Related issue number
#4581