Skip to content

Add store client and log tracking module in c++ end#984

Merged
goldenleaves merged 13 commits intoalibaba:mainfrom
goldenleaves:lgraph-client-log-tracking
Nov 16, 2021
Merged

Add store client and log tracking module in c++ end#984
goldenleaves merged 13 commits intoalibaba:mainfrom
goldenleaves:lgraph-client-log-tracking

Conversation

@goldenleaves
Copy link
Copy Markdown
Contributor

Fixes #983

@goldenleaves goldenleaves requested review from a user, LiSu and tianliplus November 12, 2021 07:05
@LiSu
Copy link
Copy Markdown
Collaborator

LiSu commented Nov 15, 2021

The name "log tracking" is confusing here, use "log subscription" instead?

@goldenleaves
Copy link
Copy Markdown
Contributor Author

The name "log tracking" is confusing here, use "log subscription" instead?

done

Copy link
Copy Markdown
Collaborator

@LiSu LiSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenleaves goldenleaves merged commit d01fb74 into alibaba:main Nov 16, 2021
@goldenleaves goldenleaves deleted the lgraph-client-log-tracking branch November 16, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add store client and log tracking module in c++ end

2 participants