Skip to content

fix(components/execd): stop sse ping after client disconnect and add smoke test#130

Merged
Pangjiping merged 1 commit intoalibaba:mainfrom
Pangjiping:hotfix/client-abort
Jan 26, 2026
Merged

fix(components/execd): stop sse ping after client disconnect and add smoke test#130
Pangjiping merged 1 commit intoalibaba:mainfrom
Pangjiping:hotfix/client-abort

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

Summary

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Pangjiping Pangjiping added the bug Something isn't working label Jan 24, 2026
@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Jan 26, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@ninan-nn ninan-nn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pangjiping Pangjiping merged commit fe90ca2 into alibaba:main Jan 26, 2026
8 checks passed
@Pangjiping Pangjiping deleted the hotfix/client-abort branch January 26, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: close ping loop after client disconnected

4 participants