Skip to content

feat(components/execd): replace sh to bash under bootstrap#134

Merged
hittyt merged 1 commit intoalibaba:mainfrom
Pangjiping:feat/execd-bootstrap-bash
Jan 29, 2026
Merged

feat(components/execd): replace sh to bash under bootstrap#134
hittyt merged 1 commit intoalibaba:mainfrom
Pangjiping:feat/execd-bootstrap-bash

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

@Pangjiping Pangjiping commented Jan 26, 2026

Summary

  • Replace sh to bash under bootstrap
  • At the beginning we used sh for maximum compatibility, but I noticed that run_command in execd is still invoked via bash, so we’ve effectively been assuming that the user’s base image includes bash all along. Therefore I’m going to change the shebang in bootstrap.sh to bash as well, so we can use more modern syntax.

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@jwx0925
Copy link
Copy Markdown
Collaborator

jwx0925 commented Jan 28, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e20fa11063

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@ninan-nn ninan-nn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 7e5cdcf into alibaba:main Jan 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants