fix(server): forward query string in sandbox proxy handler#266
Merged
Pangjiping merged 1 commit intoalibaba:mainfrom Feb 28, 2026
Merged
Conversation
The proxy handler was building the target URL using only the path component (full_path), discarding the original query string. This caused requests like /files/download?path=... to arrive at the sandbox execd without the 'path' parameter, resulting in a 400 MISSING_QUERY error. Fix by appending request.url.query to the target URL when present.
wangdengshan
requested review from
Generalwin,
Pangjiping,
hittyt and
jwx0925
as code owners
|
|
Collaborator
|
also releated to #248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/src/api/lifecycle.pywas constructing the target URL using only the path component (full_path), silently dropping the query string. This caused/files/download?path=...requests to reach the sandbox execd daemon without thepathparameter, resulting in a400 MISSING_QUERYerror.Testing
sandbox.files.read_bytes()via the Python SDK withuse_server_proxy=TrueBreaking Changes
Checklist