feat: support manual cleanup sandboxes#446
Conversation
hittyt
requested review from
Generalwin,
Pangjiping,
jwx0925 and
ninan-nn
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d45c49734f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e35ecba27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfeef4cca0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hittyt
force-pushed
the
feat/non-expire-sandbox
branch
from
cfeef4c to
639e9cb
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 639e9cb934
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sdks/code-interpreter/python/src/code_interpreter/adapters/code_adapter.py
Show resolved
Hide resolved
Pangjiping
left a comment
Pangjiping
left a comment
There was a problem hiding this comment.
LGTM. I'll be working with @Generalwin to get the kubernetes_service work done.
|
Thanks the great feature for long-running workloads. |
hittyt
force-pushed
the
feat/non-expire-sandbox
branch
from
639e9cb to
e934e56
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aa1b164a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move _parse_and_accumulate_mount_refs() before the expires/manual-cleanup branch so that OSSFS ref counts are rebuilt for all sandbox containers on server restart, not just those with expiration timers. Made-with: Cursor
TOML has no null literal; advise operators to comment out the key instead of setting it to null. Made-with: Cursor
Align default with documentation: omitting the key now truly disables the server-side upper bound instead of silently applying 86400. Made-with: Cursor
Kubernetes providers may reject null timeout when the workload provider does not support non-expiring sandboxes. Make this constraint explicit in the OpenAPI spec and schema description. Made-with: Cursor
Self-hosted runner's persisted build cache can serve stale class files from a previous branch, causing compilation errors when new methods (e.g. manualCleanup) are not found. Clean and disable build cache to ensure a fresh build every run. Made-with: Cursor
hittyt
force-pushed
the
feat/non-expire-sandbox
branch
from
436998b to
0b1b801
Compare
5 participants
Summary
nulltimeoutas non-expiring sandbox creation.expiresAtand explicit cleanup semantics.Testing
Breaking Changes
Impact:
expiresAt = nullfor manual-cleanup sandboxes.expiresAtis always a timestamp may fail when theycreate,get, orlistmanual-cleanup sandboxes.Migration path:
timeoutomitted ornull.Checklist