Skip to content

feat(specs): patch egress#454

Merged
hittyt merged 1 commit intoalibaba:mainfrom
ninan-nn:feature/patch_egress
Mar 17, 2026
Merged

feat(specs): patch egress#454
hittyt merged 1 commit intoalibaba:mainfrom
ninan-nn:feature/patch_egress

Conversation

@ninan-nn
Copy link
Collaborator

@ninan-nn ninan-nn commented Mar 16, 2026

Summary

  • Update specs/sandbox-lifecycle.yml to add egress management endpoints:
    • PATCH /sandboxes/{sandboxId}/egress
    • GET /sandboxes/{sandboxId}/egress
  • Define PATCH request body as NetworkRule[] and GET response as NetworkPolicy.
  • Clarify PATCH behavior as overwrite semantics (not append/merge):
    • for duplicate target values, the later rule overrides the earlier one (last rule wins).
  • Add request example for duplicate target to make overwrite behavior explicit.

Testing

  • Not run (spec-only change)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@ninan-nn ninan-nn marked this pull request as ready for review March 16, 2026 09:04
@ninan-nn ninan-nn requested review from hittyt and jwx0925 as code owners March 16, 2026 09:04
@Pangjiping Pangjiping added the documentation Improvements or additions to documentation label Mar 16, 2026
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt
Copy link
Collaborator

hittyt commented Mar 17, 2026

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit b7bf776 into alibaba:main Mar 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants