Skip to content

fix(sdks,server): align Host.path validation with spec across runtimes#643

Merged
Pangjiping merged 2 commits intoalibaba:mainfrom
hittyt:feat/align-host-path-validation
Apr 7, 2026
Merged

fix(sdks,server): align Host.path validation with spec across runtimes#643
Pangjiping merged 2 commits intoalibaba:mainfrom
hittyt:feat/align-host-path-validation

Conversation

@hittyt
Copy link
Copy Markdown
Collaborator

@hittyt hittyt commented Apr 5, 2026

Summary

  • Align Host.path behavior with the lifecycle spec pattern ^(/|[A-Za-z]:[\\/]) across sandbox SDKs and server validators.
  • Keep client/server validation consistent for Unix + Windows absolute host paths, and close validation-order resource-leak paths found during review.
  • Add targeted regression tests for Windows paths, drive-root handling, allowlist behavior, and early validation flow.

Testing

  • Not run (explain why)
    • C# local tests could not be run in this environment because dotnet is unavailable.
  • Unit tests
    • cd sdks/sandbox/javascript && pnpm run test
    • cd sdks/sandbox/kotlin && ./gradlew :sandbox:test
    • cd server && uv run pytest tests/test_validators.py tests/test_schema.py
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

Keep Host.path behavior consistent with the lifecycle spec by accepting Windows drive-letter absolute paths in SDKs and server validators while preserving strict backend checks. This prevents client/server drift and avoids resource leaks on early validation failures.

Made-with: Cursor
Drop the unused os import introduced during host-path validator updates so CI ruff checks pass without changing validation behavior.

Made-with: Cursor
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 446377e159

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pangjiping Pangjiping added bug Something isn't working component/server sdks labels Apr 7, 2026
Copy link
Copy Markdown
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pangjiping Pangjiping merged commit 6ff8763 into alibaba:main Apr 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component/server sdks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants