feat(platform): introduce platform support for sandbox lifecycle#645
Merged
ninan-nn merged 11 commits intoalibaba:mainfrom Apr 8, 2026
Merged
feat(platform): introduce platform support for sandbox lifecycle#645ninan-nn merged 11 commits intoalibaba:mainfrom
ninan-nn merged 11 commits intoalibaba:mainfrom
Conversation
Align platform behavior across spec, server, and SDK surfaces by adding explicit platform constraints, preserving Docker default compatibility, and failing fast only for platform-specific Kubernetes unschedulable states. Made-with: Cursor
hittyt
requested review from
Generalwin,
Pangjiping,
jwx0925 and
ninan-nn
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd6658ef73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Normalize Python and Kotlin sandbox converters to handle generated platform/network enum representations correctly, and apply formatter-compliant test imports so SDK quality checks pass consistently. Made-with: Cursor
Use dict-based API PlatformSpec construction and enum-safe value extraction so converter logic works with both string-backed and enum-backed generated models. Made-with: Cursor
Align platform handling with runtime-specific defaults, make Docker image/platform resolution safer for omitted platform requests, and document the behavior explicitly so SDK and API contracts stay consistent. Made-with: Cursor
Make pool reconcile assertions order-insensitive and harden C# code-interpreter E2E checks with retries and broader stream event acceptance to avoid timing-related false negatives. Made-with: Cursor
Update pool reconciler state test to assert set membership and cardinality instead of fixed id ordering so concurrent warmup scheduling does not cause flaky failures. Made-with: Cursor
Pangjiping
reviewed
Apr 7, 2026
…ntract Extract duplicated k8s platform selector/affinity validation into shared workload provider helpers, remove unused k8s client node read API, and realign spec/server/sdk validation to linux-only platform support for now. Made-with: Cursor
Made-with: Cursor # Conflicts: # server/opensandbox_server/services/k8s/kubernetes_service.py
Align sandbox platform conversion with linux-only OpenAPI contract to prevent Kotlin compilation failures after codegen. Made-with: Cursor
Prevent _wait_for_sandbox_ready from swallowing TypeError and timing out by restoring _normalize_create_status static dispatch. Made-with: Cursor
Made-with: Cursor # Conflicts: # tests/csharp/OpenSandbox.E2ETests/CodeInterpreterE2ETests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce an optional platform object in the sandbox lifecycle spec and treat it as a scheduling/runtime constraint rather than as part of image.
Align platform behavior across spec, server, and SDK surfaces by adding explicit platform constraints, preserving Docker default compatibility, and failing fast only for platform-specific Kubernetes unschedulable states.
Testing
Breaking Changes
Checklist