You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new cwd validation looks good for RunCommandRequest and RunInSessionRequest. One thing I wanted to double-check is the behavior of the other cwd entrypoints: CreateContext currently auto-creates the target directory via os.MkdirAll, so it does not need to follow the same validation path. But CreateSession / CreatePTYSession do not create the directory for the caller; they just carry the provided cwd forward and will fail later when the process starts. If we want invalid request.cwd to be handled consistently at the API boundary, those entrypoints should be validated as well and return 400 instead of surfacing as a later runtime failure.
Great point! I previously overlooked the cwd setup in CreateSession and CreatePTYSession. I’ve now aligned the creation flow to set up cwd as well, following a fast-fail strategy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist