Feature/secure access#745
Merged
Pangjiping merged 5 commits intoalibaba:mainfrom Apr 23, 2026
Merged
Conversation
edeea64 to
a19ee12
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a19ee125c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Pangjiping
previously approved these changes
Apr 20, 2026
hittyt
reviewed
Apr 20, 2026
a19ee12 to
e5ff793
Compare
38cd994 to
c2510f5
Compare
c2510f5 to
92e1201
Compare
92e1201 to
dd9ca75
Compare
Pangjiping
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Today, sandbox endpoints exposed through Kubernetes ingress gateway mode are reachable as long as the caller knows the public endpoint. We need an opt-in way to require an additional sandbox-scoped credential for endpoint access.
What changed
This PR adds
secureAccesssupport for sandbox endpoint access.Spec
secureAccess: booleantoCreateSandboxRequestServer
secureAccesssecureAccess=truefor Docker runtimesecureAccess=trueunless Kubernetesingress.mode='gateway'OPENSANDBOX-SECURE-ACCESSto endpoint response headersIngress
OPENSANDBOX-SECURE-ACCESSon incoming requests401when the header is missing or invalidKotlin SDK
secureAccess(...)support to sandbox builder and pool creation specsecureAccessthrough create sandbox requestsTests
Notes
secureAccessis currently supported only for Kubernetes sandboxes exposed throughingress.mode='gateway'secureAccessis omitted orfalse