feat(extensions): propagate opensandbox.extensions.* to Pod annotations#772
Merged
Pangjiping merged 4 commits intoalibaba:mainfrom Apr 25, 2026
Merged
Conversation
504097723
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efef0f4d09
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add mechanism to propagate user-specified extensions with opensandbox.extensions. prefix to Pod annotations with opensandbox.io/extensions. prefix. This enables custom metadata from Kotlin SDK to be visible on Kubernetes Pod annotations. Also fix BatchSandbox provider to include labels and annotations in Pod template metadata, ensuring they are passed to created Pods.
…ns propagation Add unit tests for apply_extensions_to_annotations covering: - Single and multiple extensions propagation - Non-prefix keys not propagated - Empty extensions handling - Preservation of existing annotations Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Remove EXTENSIONS_ANNOTATION_PREFIX and ANNOTATION_METADATA_PREFIX imports that were not used in the test file. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
504097723
force-pushed
the
feat/support-k8s-labels-annotations-
branch
from
c38dddb to
23ba097
Compare
Pangjiping
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mechanism to propagate user-specified extensions with opensandbox.extensions. prefix to Pod annotations with opensandbox.io/extensions. prefix. This enables custom metadata from Kotlin SDK to be visible on Kubernetes Pod annotations.
Also fix BatchSandbox provider to include labels and annotations in Pod template metadata, ensuring they are passed to created Pods.
Summary
What is changing and why?
This change enables custom metadata from Kotlin SDK extensions to be propagated to Kubernetes Pod annotations. Previously, user-specified extensions were only used for server-side logic (like poolRef) and were not visible on the created Pod. Now, extensions with
opensandbox.extensions.prefix are automaticallycopied to Pod annotations with
opensandbox.io/extensions.prefix.Additionally, fixed a bug where BatchSandbox provider did not include metadata in Pod template, causing labels and annotations to not be passed to created Pods.
Testing
Breaking Changes
Checklist