feat(logger): add lumberjack-backed log rotation, auto-enabled for file outputs#791
Merged
hittyt merged 3 commits intoalibaba:mainfrom Apr 27, 2026
Merged
Conversation
…le outputs Add RotateConfig to the shared internal logger. When file output paths are configured, rotation is automatically applied with defaults (100MB, 30 days, 10 backups, no compression). stdout/stderr paths are unaffected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65c9f1648f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
newWithRotate unconditionally returned nil error, masking bad file paths or permissions until write time. Add upfront sink validation matching the original zap.Config.Build behaviour. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
newWithRotate ignored cfg.ErrorOutputPaths, so zap internal diagnostics always went to default stderr regardless of configuration. Now error output sinks are opened with the same rotation support as regular log paths and wired via zap.ErrorOutput. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist