Skip to content

fix(execd): sanitize sensitive data in command logs#815

Merged
hittyt merged 1 commit intoalibaba:mainfrom
Pangjiping:hotfix/execd/sentive
May 1, 2026
Merged

fix(execd): sanitize sensitive data in command logs#815
hittyt merged 1 commit intoalibaba:mainfrom
Pangjiping:hotfix/execd/sentive

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

Summary

  • Mask passwords, tokens, API keys, cloud access keys (LTAI/AKIA/AKID), Authorization headers, and URL credentials before logging user commands. Also mask the Jupyter auth token logged at startup.

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a5022b0a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread components/execd/pkg/log/sanitize.go Outdated
@Pangjiping Pangjiping added bug Something isn't working component/execd labels Apr 29, 2026
Mask passwords, tokens, API keys, cloud access keys (LTAI/AKIA/AKID),
Authorization headers, and URL credentials before logging user commands.
Also mask the Jupyter auth token logged at startup.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 4967599 into alibaba:main May 1, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component/execd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants