refactor(server): split monolithic docker.py into modular package#832
Merged
hittyt merged 3 commits intoalibaba:mainfrom May 5, 2026
Merged
refactor(server): split monolithic docker.py into modular package#832hittyt merged 3 commits intoalibaba:mainfrom
hittyt merged 3 commits intoalibaba:mainfrom
Conversation
Replace 2698-line docker.py with focused mixin modules: - docker_service.py: core orchestration, CRUD, public API - container_ops.py: image management, platform resolution, container creation - networking.py: network validation, endpoints, egress sidecar - volumes.py: volume validation, bind mounts, PVC - runtime.py: execd distribution, bootstrap launcher Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pangjiping
requested review from
Generalwin,
hittyt,
jwx0925 and
ninan-nn
as code owners
- Move docker_diagnostics, port_allocator, ossfs_mixin into docker/ - Move docker_snapshot_runtime into docker/ - Split docker_windows_profile into docker/windows_profile (Docker-specific) and windows_profile_common (shared with k8s) - Update all import paths across codebase and tests Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Shorter name, same semantics. Linter also trimmed unused imports. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace 2698-line docker.py with focused mixin modules:
Testing
Breaking Changes
Checklist