feat(snapshot): support public snapshots api on Kubernetes runtime#837
feat(snapshot): support public snapshots api on Kubernetes runtime#837ninan-nn merged 3 commits intoalibaba:mainfrom
Conversation
Implement Kubernetes-backed public snapshot creation by creating and watching SandboxSnapshot CRs from the lifecycle server. Persist the selected restore image, support restart recovery for in-progress snapshots, and require the source sandbox to be Running before accepting snapshot creation. Separate public snapshot image tags from internal pause/resume tags: pause/resume snapshots keep snap-gen<N> via BatchSandbox ownerReference, while server-managed snapshots use stable snapshot-id-derived tags. Update API/docs to clarify Kubernetes snapshot delete semantics, add focused server/controller tests, and include a manual K8s snapshot debug runner for create, snapshot, restore, and cleanup verification.
# Conflicts: # server/tests/test_snapshot_runtime_factory.py
fengcone
requested review from
Generalwin,
Pangjiping,
Spground,
hittyt,
jwx0925,
kevinlynx and
ninan-nn
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64edfc3a3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengcone
added
component/k8s
ninan-nn
left a comment
ninan-nn
left a comment
There was a problem hiding this comment.
Server related code reviewed, LGTM. Server tests should be fixed.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5 participants
Summary
Implement Kubernetes-backed public snapshot creation by creating and
watching SandboxSnapshot CRs from the lifecycle server. Persist the
selected restore image, support restart recovery for in-progress
snapshots, and require the source sandbox to be Running before accepting
snapshot creation.
Separate public snapshot image tags from internal pause/resume tags:
pause/resume snapshots keep snap-gen via BatchSandbox ownerReference,
while server-managed snapshots use stable snapshot-id-derived tags.
Update API/docs to clarify Kubernetes snapshot delete semantics, add
focused server/controller tests, and include a manual K8s snapshot debug
runner for create, snapshot, restore, and cleanup verification.
Testing
Breaking Changes
Checklist