Skip to content

fix(sdk-go): forward all GetEndpoint headers on subsequent requests#900

Merged
ninan-nn merged 1 commit into
alibaba:mainfrom
Pangjiping:fix/sdk-go-forward-endpoint-headers
May 18, 2026
Merged

fix(sdk-go): forward all GetEndpoint headers on subsequent requests#900
ninan-nn merged 1 commit into
alibaba:mainfrom
Pangjiping:fix/sdk-go-forward-endpoint-headers

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

@Pangjiping Pangjiping commented May 17, 2026

Summary

Mirror the Python SDK behavior where every header returned by the lifecycle GetEndpoint call (auth tokens, routing hints, sticky-session keys, etc.) is forwarded as-is on every subsequent execd/egress request. The previous code extracted only the X-EXECD-ACCESS-TOKEN / OPENSANDBOX-EGRESS-AUTH header and dropped the rest, which broke routing when the server added new headers.

closes #886

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

Mirror the Python SDK behavior where every header returned by the
lifecycle GetEndpoint call (auth tokens, routing hints, sticky-session
keys, etc.) is forwarded as-is on every subsequent execd/egress request.
The previous code extracted only the X-EXECD-ACCESS-TOKEN /
OPENSANDBOX-EGRESS-AUTH header and dropped the rest, which broke routing
when the server added new headers.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@Pangjiping Pangjiping requested a review from ninan-nn as a code owner May 17, 2026 06:05
@Pangjiping Pangjiping added the bug Something isn't working label May 17, 2026
@Pangjiping Pangjiping requested review from hittyt and jwx0925 as code owners May 17, 2026 06:05
Copy link
Copy Markdown
Collaborator

@ninan-nn ninan-nn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ninan-nn ninan-nn merged commit 84e9e06 into alibaba:main May 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working sdk/go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GO SDK headers

2 participants